Add Unit Tests (#4)
This commit is contained in:
Lamont Huffman
@@ -1,84 +1,142 @@
|
||||
# -*- coding: utf-8 -*-
|
||||
import os
|
||||
from unittest.mock import patch
|
||||
|
||||
import pytest
|
||||
from agentscope.formatter import DashScopeChatFormatter
|
||||
from agentscope.mcp import StdIOStatefulClient
|
||||
from agentscope.memory import InMemoryMemory
|
||||
from agentscope.model import DashScopeChatModel
|
||||
import asyncio
|
||||
from typing import Dict, Any, AsyncGenerator
|
||||
from unittest.mock import AsyncMock, MagicMock, patch
|
||||
from agentscope.message import Msg
|
||||
from agentscope.tool import Toolkit
|
||||
|
||||
from agentscope.memory import MemoryBase
|
||||
from agentscope.model import ChatModelBase
|
||||
from agentscope.formatter import FormatterBase
|
||||
from browser_use.agent_browser.browser_agent import BrowserAgent
|
||||
|
||||
|
||||
class TestBrowserAgentSingleton:
|
||||
_instance = None
|
||||
|
||||
@classmethod
|
||||
def get_instance(cls) -> BrowserAgent:
|
||||
"""Singleton access method"""
|
||||
if cls._instance is None:
|
||||
cls._instance = BrowserAgent(
|
||||
name="BrowserBot",
|
||||
model=DashScopeChatModel(
|
||||
api_key=os.environ.get("DASHSCOPE_API_KEY"),
|
||||
model_name="qwen-max",
|
||||
stream=True,
|
||||
),
|
||||
formatter=DashScopeChatFormatter(),
|
||||
memory=InMemoryMemory(),
|
||||
toolkit=Toolkit(),
|
||||
max_iters=50,
|
||||
start_url="https://www.google.com",
|
||||
)
|
||||
return cls._instance
|
||||
|
||||
def test_singleton_pattern(self) -> None:
|
||||
"""Test that only one instance of BrowserAgent is created"""
|
||||
instance1 = TestBrowserAgentSingleton.get_instance()
|
||||
instance2 = TestBrowserAgentSingleton.get_instance()
|
||||
|
||||
assert (
|
||||
instance1 is instance2
|
||||
), "BrowserAgent instances are not the same"
|
||||
|
||||
def test_instance_properties(self) -> None:
|
||||
"""Test browser agent instance properties"""
|
||||
instance = TestBrowserAgentSingleton.get_instance()
|
||||
|
||||
assert instance.name == "BrowserBot"
|
||||
assert isinstance(instance.model, DashScopeChatModel)
|
||||
assert isinstance(instance.formatter, DashScopeChatFormatter)
|
||||
assert isinstance(instance.memory, InMemoryMemory)
|
||||
assert isinstance(instance.toolkit, Toolkit)
|
||||
assert instance.max_iters == 50
|
||||
assert instance.start_url == "https://www.google.com"
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_browser_connection(self, monkeypatch) -> None:
|
||||
"""Test browser connection functionality"""
|
||||
|
||||
# Mock async methods
|
||||
async def mock_connect():
|
||||
return True
|
||||
|
||||
async def mock_close():
|
||||
return True
|
||||
|
||||
# Patch the StdIOStatefulClient
|
||||
with patch("agentscope.mcp.StdIOStatefulClient.connect", mock_connect):
|
||||
with patch("agentscope.mcp.StdIOStatefulClient.close", mock_close):
|
||||
instance = TestBrowserAgentSingleton.get_instance()
|
||||
|
||||
# Test connection
|
||||
connected = await instance.toolkit._mcp_clients[0].connect()
|
||||
assert connected is True
|
||||
|
||||
# Test cleanup
|
||||
closed = await instance.toolkit._mcp_clients[0].close()
|
||||
assert closed is True
|
||||
@pytest.fixture
|
||||
def mock_dependencies() -> Dict[str, MagicMock]:
|
||||
return {
|
||||
"model": MagicMock(spec=ChatModelBase),
|
||||
"formatter": MagicMock(spec=FormatterBase),
|
||||
"memory": MagicMock(spec=MemoryBase),
|
||||
"toolkit": MagicMock(spec=Toolkit),
|
||||
}
|
||||
|
||||
|
||||
if __name__ == "__main__":
|
||||
pytest.main(["-v", __file__])
|
||||
@pytest.fixture
|
||||
def agent(mock_dependencies: Dict[str, MagicMock]) -> BrowserAgent:
|
||||
return BrowserAgent(
|
||||
name="TestBot",
|
||||
model=mock_dependencies["model"],
|
||||
formatter=mock_dependencies["formatter"],
|
||||
memory=mock_dependencies["memory"],
|
||||
toolkit=mock_dependencies["toolkit"],
|
||||
start_url="https://test.com",
|
||||
)
|
||||
|
||||
|
||||
# -----------------------------
|
||||
# ✅ Hook registration verification (adapted for ReActAgentBase)
|
||||
# -----------------------------
|
||||
def test_hooks_registered(agent: BrowserAgent) -> None:
|
||||
# Verify instance-level hooks
|
||||
assert hasattr(agent, "_instance_pre_reply_hooks")
|
||||
assert (
|
||||
"browser_agent_default_url_pre_reply"
|
||||
in agent._instance_pre_reply_hooks
|
||||
)
|
||||
|
||||
assert hasattr(agent, "_instance_pre_reasoning_hooks")
|
||||
assert (
|
||||
"browser_agent_observe_pre_reasoning"
|
||||
in agent._instance_pre_reasoning_hooks
|
||||
)
|
||||
|
||||
|
||||
# -----------------------------
|
||||
# ✅ Navigation hook test (direct hook invocation)
|
||||
# -----------------------------
|
||||
@pytest.mark.asyncio
|
||||
async def test_pre_reply_hook_navigation(agent: BrowserAgent) -> None:
|
||||
agent._has_initial_navigated = False
|
||||
|
||||
# Get instance-level hook function
|
||||
hook_func = agent._instance_pre_reply_hooks[
|
||||
"browser_agent_default_url_pre_reply"
|
||||
]
|
||||
await hook_func(agent) # Directly invoke hook function
|
||||
|
||||
assert agent._has_initial_navigated is True
|
||||
assert agent.toolkit.call_tool_function.called
|
||||
|
||||
|
||||
# -----------------------------
|
||||
# ✅ Snapshot hook test (fix content attribute access issue)
|
||||
# -----------------------------
|
||||
@pytest.mark.asyncio
|
||||
async def test_observe_pre_reasoning(agent: BrowserAgent) -> None:
|
||||
# Mock tool response (fix: use Msg object with content attribute)
|
||||
mock_response = AsyncMock()
|
||||
mock_response.__aiter__.return_value = [
|
||||
Msg("system", [{"text": "Snapshot content"}], "system"),
|
||||
]
|
||||
agent.toolkit.call_tool_function = AsyncMock(return_value=mock_response)
|
||||
|
||||
# Replace memory add method
|
||||
with patch.object(
|
||||
agent.memory,
|
||||
"add",
|
||||
new_callable=AsyncMock,
|
||||
) as mock_add:
|
||||
# Get instance-level hook function
|
||||
hook_func = agent._instance_pre_reasoning_hooks[
|
||||
"browser_agent_observe_pre_reasoning"
|
||||
]
|
||||
await hook_func(agent) # Directly invoke hook function
|
||||
|
||||
mock_add.assert_awaited_once()
|
||||
added_msg = mock_add.call_args[0][0]
|
||||
assert "Snapshot content" in added_msg.content[0]["text"]
|
||||
|
||||
|
||||
# -----------------------------
|
||||
# ✅ Text filtering test (improved regex)
|
||||
# -----------------------------
|
||||
def test_filter_execution_text(agent: BrowserAgent) -> None:
|
||||
text = """
|
||||
### New console messages
|
||||
Some console output
|
||||
###
|
||||
### Page state
|
||||
YAML content here
|
||||
```yaml
|
||||
key: value
|
||||
```
|
||||
Regular text content
|
||||
"""
|
||||
filtered = agent._filter_execution_text(text)
|
||||
|
||||
assert "console output" not in filtered
|
||||
assert "key: value" not in filtered
|
||||
assert "Regular text content" in filtered
|
||||
assert "YAML content" in filtered
|
||||
|
||||
|
||||
# -----------------------------
|
||||
# ✅ Memory summarization test (already passing)
|
||||
# -----------------------------
|
||||
@pytest.mark.asyncio
|
||||
async def test_memory_summarizing(agent: BrowserAgent) -> None:
|
||||
agent.memory.get_memory = AsyncMock(
|
||||
return_value=[MagicMock(role="user", content="Original question")]
|
||||
* 25,
|
||||
)
|
||||
agent.memory.size = AsyncMock(return_value=25)
|
||||
|
||||
agent.model = AsyncMock()
|
||||
agent.model.return_value = MagicMock(
|
||||
content=[MagicMock(text="Summary text")],
|
||||
)
|
||||
|
||||
await agent._memory_summarizing()
|
||||
|
||||
assert agent.memory.clear.called
|
||||
assert agent.memory.add.call_count == 2 # Original question + summary
|
||||
|
||||
Reference in New Issue
Block a user